Skip to content

Q
qt-creator
Source
Select Git revision
...
Target
Select Git revision
 
Commits (2)
  • Oswald Buddenhagen's avatar
    fix build with qt 4.7 · 245f8652
    Oswald Buddenhagen authored 
    it is source-incompatible to this broken code :)
    245f8652
  • Oswald Buddenhagen's avatar
    fix security hole: don't add an empty element to LD_LIBRARY_PATH · 3c00715c
    Oswald Buddenhagen authored 
    if LD_LIBRARY_PATH was empty, the wrapper script would add the empty
element to the path.

> The trailing colon is treated by ld.so as another item on the list,
> and empty items are treated as '.' (CWD). Therefore, if a user
> executes qtcreator from a directory where there's a library that would
> have normally been loaded from the standard library paths the local
> library would be loaded instead.
> This has the potential effect of arbitrary code execution.

Reviewed-by: thiago
Task-number: CVE-2010-3374
    3c00715c
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 3 deletions
bin/qtcreator
View file @ 3c00715c
......@@ -31,6 +31,6 @@ fi
bindir=`dirname "$me"`
libdir=`cd "${bindir}/../lib" ; pwd`
LD_LIBRARY_PATH="${libdir}/qtcreator:${LD_LIBRARY_PATH}"
LD_LIBRARY_PATH="${libdir}/qtcreator${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"
export LD_LIBRARY_PATH
exec "${bindir}/qtcreator.bin" ${1+"$@"}
src/libs/cplusplus/TypePrettyPrinter.cpp
View file @ 3c00715c
......@@ -69,8 +69,7 @@ static QString fullyQualifiedName(Symbol *symbol, const Overview *overview)
}
TypePrettyPrinter::TypePrettyPrinter(const Overview *overview)
: _overview(overview),
_name(0)
: _overview(overview)
{ }
TypePrettyPrinter::~TypePrettyPrinter()
......