Skip to content
Snippets Groups Projects

Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Select target project
No results found

Target

Select target project
  • tohunger/qt-creator
1 result
Show changes
Commits on Source (2)
  • Oswald Buddenhagen's avatar
    fix build with qt 4.7 · 245f8652
    Oswald Buddenhagen authored 
    it is source-incompatible to this broken code :)
    245f8652
  • Oswald Buddenhagen's avatar
    fix security hole: don't add an empty element to LD_LIBRARY_PATH · 3c00715c
    Oswald Buddenhagen authored 
    if LD_LIBRARY_PATH was empty, the wrapper script would add the empty
element to the path.

> The trailing colon is treated by ld.so as another item on the list,
> and empty items are treated as '.' (CWD). Therefore, if a user
> executes qtcreator from a directory where there's a library that would
> have normally been loaded from the standard library paths the local
> library would be loaded instead.
> This has the potential effect of arbitrary code execution.

Reviewed-by: thiago
Task-number: CVE-2010-3374
    3c00715c
Hide whitespace changes
Inline Side-by-side
bin/qtcreator
View file @ 3c00715c
......@@ -31,6 +31,6 @@ fi
bindir=`dirname "$me"`
libdir=`cd "${bindir}/../lib" ; pwd`
LD_LIBRARY_PATH="${libdir}/qtcreator:${LD_LIBRARY_PATH}"
LD_LIBRARY_PATH="${libdir}/qtcreator${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"
export LD_LIBRARY_PATH
exec "${bindir}/qtcreator.bin" ${1+"$@"}
src/libs/cplusplus/TypePrettyPrinter.cpp
View file @ 3c00715c
......@@ -69,8 +69,7 @@ static QString fullyQualifiedName(Symbol *symbol, const Overview *overview)
}
TypePrettyPrinter::TypePrettyPrinter(const Overview *overview)
: _overview(overview),
_name(0)
: _overview(overview)
{ }
TypePrettyPrinter::~TypePrettyPrinter()
......