Change-Id: I9d0abacbd1b503390164934a1b833fd305ae3fbe
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I4297651458f6efb28a3bbeb83b4c038956d64305
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I7c2dc83143aab2c2c0e16736dd26c53c75de024a
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I018682bfb6bfc9fec77f8e4996cff5b6fd15c526
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I365e4c56b45dda205caa009e7733579d40bca9d0
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I9b9081df454aae35c42744f4bbd385e8bd6c50d2
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I4f71448d6788a4e553b1495b72263a004e65d8c0
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: Ic935a8971705cb3238deda71aa2b5d19e4f62593
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I7053310272235d854c9f409670ff52a10a7add8b
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I0423cf1b710c5522d494e95b2076f52c06e68ab0
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Also when duplicating editors, we don't want to change the document
after construction. Actually at some places (e.g. CppEditorSupport
creation) we don't handle document changes correctly, and we are only
lucky that things still (more or less?) work. Get rid of
BaseTextEditorWidget::duplicateFrom and use copy-constructor style instead.

Change-Id: I7f688b7fcc51d1bb5e222bb333f0d28479b597a6
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

First step in never changing the text document after construction,
because that is actually not really supported.
Second step will be to fix that for the editor duplicate() methods too.

Change-Id: I3d112ba0895e7ee7ac6dd8ae2318f0de7d2cebc9
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

This patch also moves the showMargin and marginColumn settings into a
new settings class.

Change-Id: I676447be751c13ee438edc1e31e5998b999c6771
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

It was never called with a sensible value anyhow, and only complicates things.

Change-Id: I005848700b6c00114d91495670d4a0e15a2d2e64
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: Ib5423fdd064e4546f848c0b640b0ed0514c26d3a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

There is a 1-to-1 relationship between BaseTextDocument and QTextDocument,
so it doesn't make sense to do the setup between them in the editor widget.

Move creation of BaseTextDocumentLayout and setting up of 'changed' signal
to BaseTextDocument. This also avoids sending multiple
'changed' signals for a single QTextDocument::modificationChanged signal
in case of splits.

Change-Id: Iaab4fea594c5b50f502fd41c88948fac132de9f1
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: Ife6b1dc4059190ce7f04fe5f8b7e4ee517f6ce5c
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Change-Id: I50a32f435451ffb8991f5e0c0d7e7da950ce19c9
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

+ Sort the includes

Change-Id: Ia6a5afdaa42c24c9ec0f66748aec1b6224561ab7
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Change-Id: I6124c12a269093fbd54cbbbb47b4d7f15ffaae2f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Doesn't really make sense to have the additional IDocument *editorDocument()
method.

Change-Id: I0a7420eb1afaa76f63c3f7e9c4b373acf624ffb9
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

The action handler implicitly passed ownership to ICore, which is non-
to the action handler. We now consistently create the action handler in
the editor factory, give ownership to the editor factory, and don't hold
a reference to it.

Change-Id: I4372f8de966e3ceff87c06c5528c6b54522c1d57
Reviewed-by: David Schulz <david.schulz@digia.com>

The action handler already knows which editors to handle through the
context. It only needs to receive signals for updating the actions from
the current editor. So there is no need to tell the action handler about
every individual editor. This also removes some noise from the text
editor implementations.

Change-Id: I76dc5b1559cc8cf54ff313e6cdba4e789a3108aa
Reviewed-by: David Schulz <david.schulz@digia.com>

The actionHack was used to only forward actions to editors that "belong"
to that action handler instance. That is already clearly defined by the
context that the action handler is created for, so we can just use that
instead.

Change-Id: Ia4c6795c80bb281c1ed258324925f56ca7fd8150
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

The default "matches" method now takes the widget and looks for all
child labels, checkboxes, push buttons and group boxes.
Because of that, the former "createWidget" method
can be called multiple times without creating a new widget
(-->widget()), and the "finished" method must ensure that the created
widget gets deleted, since not all widgets that were created are added
to the UI anymore.

Change-Id: Ia231c7c78dd8819146668e6447d36d22e7836904
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

And remove the indirection over BaseTextEditorWidget.

Change-Id: I2c570edf46b9ca72a11704ce27d8ae3f2218dcf0
Reviewed-by: David Schulz <david.schulz@digia.com>

To differentiate it from the byte array based IDocument::setContents

Change-Id: Icc9600732c2742fb79254a0697870bacce3a59ee
Reviewed-by: David Schulz <david.schulz@digia.com>

Change-Id: I9f8681a8d975558e5e8626566df73ac8438c4cef
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>

Change-Id: I32f7ee73474bd9a5c1d7d435d4d2969c4126662a
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I9dab955a0b4a0d7d83a69cfc474633be43e7169f
Reviewed-by: David Schulz <david.schulz@digia.com>

Change-Id: I8dd6861219bc8221030a850779baed2a596d5944
Reviewed-by: David Schulz <david.schulz@digia.com>

Remove the TextBlockUserData base class BlockData and store the data of
this class inside a CodeFormatter base class. This class can be added to the
TextBlockUserData via setCodeFormatterData. Now we don't have to assume
that the user data is a specific base class of TextBlockUserData.

This removes a crash where the TextBlockUserData was created before the
highlighter could create and set his base class.

Task-number: QTCREATORBUG-10871

Change-Id: I167bdb68b9b1fecc64e4906bdad60bfbecb3bf47
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I80d889c4db32d5ee69d3cfea0adadd96a44a7751
Reviewed-by: David Schulz <david.schulz@digia.com>

- Added the right TextFormat for dsFunction
- Added TODO comments for missing dsError and dsAlert

Task-number: QTCREATORBUG-10788
Change-Id: I31862971ac5b47f13036aa9c55552778ad88d4ee
Reviewed-by: Thomas Boutroue <thebootroo@gmail.com>
Reviewed-by: David Schulz <david.schulz@digia.com>

Change-Id: I2e8ac37b2e980bed88e270ccd10cb7319f1f9ffd
Reviewed-by: David Schulz <david.schulz@digia.com>

Change-Id: I8413252c90a1487d291f15d92837c30ab697b245
Reviewed-by: hjk <hjk121@nokiamail.com>

...otherwise subsequent events (e.g. Return) might trigger functions
operating on an invalid model index (see activateCurrentProposalItem).

Task-number: QTCREATORBUG-10589

Change-Id: Ib3e37c8c85c882135970d5d9418d6e69917494c6
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

Broke with f1eb9c48 which exchanged
setDefaultKeySequence with setKeySequence

Task-number: QTCREATORBUG-10538
Change-Id: Id40bd8fd403cd586a39a19c248f59e23cf4cf8c0
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: David Schulz <david.schulz@digia.com>

...since it does not make sense for TextEditor::QuickFix and
TextEditor::FollowSymbol.

Regarding the bug:
- The bug was exposed by having "Active completion" set to *not*
  "Manual" in Options > Text Editor > Completion.
- After choosing one item from the overrides list the cursor was
  positioned just right before the beginning of a function name, which
  is a valid activation sequence (see CodeAssistantPrivate::process()))
  As a consequence, a new proposal was requested.

Task-number: QTCREATORBUG-10345
Change-Id: Ib0d10192863fb33c0958a9afbf76ca8e7de772f8
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

Task-number: QTCREATORBUG-9188

Change-Id: I3448645397e7a39487f2e961728ebef924eec7f6
Reviewed-by: Eike Ziller <eike.ziller@digia.com>