Done with Thorbjorn and Roberto

done with roberto

When the path to the shipped color schemes changes, Qt Creator was
unable to load the chosen color scheme. Now, when it can't find the
color scheme, it will look for it in the default color scheme path.

Reviewed-by: con

Task: QTCREATORBUG-543
Reviewed-by: Tobias Hunger

They were no longer showing e.g. the file name of the diffed file.
Also separate editor id and editor context a bit.

When the bookmark could not be added to the editor due to being on a
non-existing line, it would not be cleaned up properly when the editor
was closed, resulting in a crash when it later tried to remove itself
from the no longer existing editor.

In addition to fixing the crash, bookmarks that are not on valid lines
are now automatically removed when you try to navigate to them.

Task-number: QTCREATORBUG-545
Reviewed-by: mae

Reviewed-by: thorbjorn

Reviewed-by: thorbjorn

  * Use id() for methods returning a string used to represent
    some type of object.
  * Use displayName() for strings that are meant to be user
    visible.
  * Quieten some warnings while touching the files anyway.
  * Move Factories to their products in the plugins where that
    was not done before.

Reviewed-by: dt

the fakevim plugin needs access to this method for automatic indenting as the implementation
differs across the different types of editors

Merge-request: 98
Reviewed-by: hjk <qtc-committer@nokia.com>

As it causes dashed lists to be formatted as
- i1
  - i2
Just do paragraph formatting.

Task-number: QTCREATORBUG-538
Initial-patch-by: Thorbjørn Lindeijer <thorbjorn.lindeijer@nokia.com>
(cherry picked from commit 2986ccaf)

As it causes dashed lists to be formatted as
- i1
  - i2
Just do paragraph formatting.

Task-number: QTCREATORBUG-538
Initial-patch-by: Thorbjørn Lindeijer <thorbjorn.lindeijer@nokia.com>

- this is compatible with choosing completion items in vim
- especially when using FakeVim mode, this makes it unnecessary to move
  the hands from the main row to the arrow keys

Merge-request: 2158
Reviewed-by: hjk <qtc-committer@nokia.com>

This uses the same UI as "Rename Symbol".
Moves the actual rename implementation to a static method in
BaseFileFind and uses it for rename symbol and search & replace.
Moves the signal notification for the code model from VCSManager to
the more general FileManager.
Note that as for rename symbol, there's no undo yet.

Task-number: QTCREATORBUG-73

Remember the read-only state so that it can be taken into account when
changing the enabled state of the erase background button.

The dummy shortcut eater did not always work, we sometimes do have
mutual exclusive shortcuts in the same context.

The current solution is simpler: ignore text input when the control modifier
is used. This seems to be in line with other toolkits and applications.

Done with: thorbjorn

If the first or last line in a selection ended up with nothing to
highlight after whitespaces were trimmed, they'd use a codepath that
only works correctly for inner 'empty' lines.

Instead we now make sure the beginning and end of a selection are always
highlighted.

QTCREATORBUG-456

It activates too easily for some people.

Task-number: QTCREATORBUG-406

It used to be hidden on the Display settings page.

Task-number: QTCREATORBUG-135

Before, the selection was required to span multiple lines. Now, any
selection will trigger the line indenting functionality of
Tab/Shift+Tab. This should lead to less surprises.

Also, Shift+Tab will now always unindent the current line, even if there
is no selection, since there is nothing else sensible for this shortcut
to do.

Task-number: QTCREATORBUG-414
Reviewed-by: mae

Done with: mae

the new approach makes it possible to use more edit features
inside the rename selection like cut/copy/paste. Furthermore
it compresses rename operations better on the undo stack.

When auto-indent is turned off, Qt Creator uses a simplistic approach of
copying the indentation string from the previous line. This was broken
when the cursor was positioned inside the indentation, since this caused
part of the indentation to go to the next line, which was then prepended
with the copied indentation, in effect increasing the indentation for
each new line.

The solution here was to copy the indentation from the previous block
only after inserting the new block, which causes the indentation of the
previous line to be cut off by exactly the right amount to keep the
indentation constant.

Task-number: QTCREATORBUG-396
Reviewed-by: mae

done with thorbjorn